Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled #15204

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Fix flaky test MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled #15204

merged 5 commits into from
Sep 3, 2024

Conversation

sumitasr
Copy link
Member

@sumitasr sumitasr commented Aug 12, 2024 •
edited
Loading

Description

Fix flaky test MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled

  • Fixed assertions.

Related Issues

Resolves #15117

Check List

  • [NA] Functionality includes testing.
  • [NA] API changes companion pull request created, if applicable.
  • [Yes] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sumitasr sumitasr changed the title Fix test MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled Fix flaky test MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled Aug 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 338a7f6: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.97%. Comparing base (e5fadba) to head (54625f3).
Report is 31 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15204      +/-   ##
============================================
+ Coverage     71.89%   71.97%   +0.08%     
- Complexity    63496    63523      +27     
============================================
  Files          5244     5244              
  Lines        296836   296836              
  Branches      42860    42860              
============================================
+ Hits         213401   213652     +251     
+ Misses        65966    65650     -316     
- Partials      17469    17534      +65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sumitasr sumitasr marked this pull request as ready for review August 12, 2024 06:38
@SwethaGuptha SwethaGuptha mentioned this pull request Aug 28, 2024
Open
3 tasks
@andrross
Copy link
Member

@sumitasr I don't think we saw this test failing in the past. What changed? I would feel better about removing the assertions here if we fully understand what changed to make this test intermittently fail when in the past it never failed.

@sumitasr sumitasr requested a review from jainankitk as a code owner August 29, 2024 06:16
@sumitasr
Copy link
Member Author

sumitasr commented Aug 29, 2024 •
edited
Loading

❌ Gradle check result for 98ffaa7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Fixed. Incorrect assert was added.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for afa9b91: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sumitasr
Copy link
Member Author

❌ Gradle check result for afa9b91: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Test Result (no failures)

Looks like need to rerun again

@sumitasr
Retry Build
30e379a 
Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 30e379a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sumitasr
Copy link
Member Author

❌ Gradle check result for 30e379a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Following is the failure log in build. Looks like issue with test run infra setup.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> JAVA17_HOME required

@sumitasr
Retry Build
2819a90 
Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2819a90: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for a32ae3a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sumitasr
Copy link
Member Author

❕ Gradle check result for a32ae3a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Failed due to Test Result (2 failures / +2)

[org.opensearch.search.SearchTimeoutIT.testSimpleTimeout {p0={"search.concurrent_segment_search.enabled":"false"}}](https://build.ci.opensearch.org/job/gradle-check/45765/testReport/junit/org.opensearch.search/SearchTimeoutIT/testSimpleTimeout__p0___search_concurrent_segment_search_enabled___false___/)
[org.opensearch.search.SearchTimeoutIT.testSimpleTimeout {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/45765/testReport/junit/org.opensearch.search/SearchTimeoutIT/testSimpleTimeout__p0___search_concurrent_segment_search_enabled___true___/)

Need to retry build

@sumitasr
Retry Build
54625f3 
Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 54625f3: SUCCESS

@sumitasr sumitasr marked this pull request as ready for review August 29, 2024 18:09
@sumitasr sumitasr mentioned this pull request Aug 30, 2024
Closed
@shwetathareja shwetathareja added skip-changelog backport 2.x Backport to 2.x branch labels Sep 3, 2024
@shwetathareja shwetathareja merged commit b23c9de into opensearch-project:main Sep 3, 2024
43 of 45 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
@github-actions
Fix flaky test MasterServiceTests.testClusterStateUpdateLoggingWithDe…
87ff7f0 
…bugEnabled (#15204)

* Fix test MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
(cherry picked from commit b23c9de)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 3, 2024
Merged
dblock pushed a commit that referenced this pull request Sep 3, 2024
@opensearch-trigger-bot @github-actions
Fix flaky test MasterServiceTests.testClusterStateUpdateLoggingWithDe…
c8bed7c 
…bugEnabled (#15204) (#15597)

* Fix test MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled


(cherry picked from commit b23c9de)

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 6, 2024
Open
Open
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@sumitasr @akolarkunnu
Fix flaky test MasterServiceTests.testClusterStateUpdateLoggingWithDe…
d83d522 
…bugEnabled (opensearch-project#15204)

* Fix test MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 24, 2024
Closed
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@sumitasr @dk2k
Fix flaky test MasterServiceTests.testClusterStateUpdateLoggingWithDe…
5bd713c 
…bugEnabled (opensearch-project#15204)

* Fix test MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@sumitasr @dk2k
Fix flaky test MasterServiceTests.testClusterStateUpdateLoggingWithDe…
890d189 
…bugEnabled (opensearch-project#15204)

* Fix test MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@sumitasr @dk2k
Fix flaky test MasterServiceTests.testClusterStateUpdateLoggingWithDe…
405788e 
…bugEnabled (opensearch-project#15204)

* Fix test MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 left review comments

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumitasr @andrross @shwetathareja @owaiskazi19